Re: BUG #15548: Unaccent does not remove combining diacritical characters

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Hugh Ranalli <hugh(at)whtc(dot)ca>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, thomas(dot)munro(at)enterprisedb(dot)com, Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: 2019-01-28 06:45:45
Message-ID: 20190128064545.GD15401@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Thomas,

On Thu, Jan 10, 2019 at 03:09:45PM +0900, Michael Paquier wrote:
> OK, committed then. I have yet to study yet the other part of the
> proposal regarding diatritical characters. Patch 3 has a conflict for
> the regression tests, so a rebase would be needed. That's not a big
> deal though to resolve the conflict. I am also a bit confused by the
> newly-generated unaccent.rules. Why nothing shows up for the second
> column (around line 414 for example)? Shouldn't we have mapping
> characters?

You are registered as a reviewer and committer of the last patch of
this thread:
https://commitfest.postgresql.org/21/1924/

Are you planning to look at it or should I jump in? I have not looked
at the patch status in depth yet.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2019-01-28 07:26:29 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Andres Freund 2019-01-28 04:50:34 Re: Why PG_SETMASK() change errno to 0 when there is an elog() call before or after it? Is it a bug?

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuro Yamada 2019-01-28 06:53:21 Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Previous Message Michael Paquier 2019-01-28 06:31:12 Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS