| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Hugh Ranalli <hugh(at)whtc(dot)ca> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, thomas(dot)munro(at)enterprisedb(dot)com, Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15548: Unaccent does not remove combining diacritical characters |
| Date: | 2019-01-10 06:09:45 |
| Message-ID: | 20190110060945.GL2157@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Jan 09, 2019 at 09:52:05PM -0500, Hugh Ranalli wrote:
> Thank you for putting so much effort into this. I think that looks great.
> When I was doing this, I discovered that I could parse both pre- and post-
> r29 versions, so I went with that, but I agree that there's probably no
> good reason to do so.
OK, committed then. I have yet to study yet the other part of the
proposal regarding diatritical characters. Patch 3 has a conflict for
the regression tests, so a rebase would be needed. That's not a big
deal though to resolve the conflict. I am also a bit confused by the
newly-generated unaccent.rules. Why nothing shows up for the second
column (around line 414 for example)? Shouldn't we have mapping
characters?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AP | 2019-01-10 08:22:00 | Re: BUG #15582: ALTER TABLE/INDEX ... SET TABLESPACE does not free disk space |
| Previous Message | AP | 2019-01-10 03:58:22 | Re: BUG #15582: ALTER TABLE/INDEX ... SET TABLESPACE does not free disk space |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2019-01-10 06:31:18 | Re: Fast path for empty relids in check_outerjoin_delay() |
| Previous Message | Etsuro Fujita | 2019-01-10 06:07:01 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |