Re: index_build does not need its isprimary argument

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: index_build does not need its isprimary argument
Date: 2019-01-23 23:02:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jan 22, 2019 at 05:08:52PM +0900, Michael Paquier wrote:
> While working on REINDEX CONCURRENTLY, I have noticed that
> index_build() does not need its argument isprimary. Perhaps it is
> not worth bothering, but for the REINDEX CONCURRENTLY business this
> removes the need to open an index when triggering a concurrent
> build.
> The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
> finish the cleanup as index_update_stats() has simplified its
> interface.

And committed as of 289198c, and back to the real deal..

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2019-01-23 23:21:45 Re: Protect syscache from bloating with negative cache entries
Previous Message Tom Lane 2019-01-23 23:01:35 Re: Thread-unsafe coding in ecpg