| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | index_build does not need its isprimary argument |
| Date: | 2019-01-22 08:08:52 |
| Message-ID: | 20190122080852.GB3873@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While working on REINDEX CONCURRENTLY, I have noticed that
index_build() does not need its argument isprimary. Perhaps it is
not worth bothering, but for the REINDEX CONCURRENTLY business this
removes the need to open an index when triggering a concurrent
build.
The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
finish the cleanup as index_update_stats() has simplified its
interface.
Are there any objections if I cleanup that stuff as per the attached?
Thanks,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| index-build-isprimary.patch | text/x-diff | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-01-22 08:58:29 | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |
| Previous Message | Imai, Yoshikazu | 2019-01-22 07:00:54 | RE: speeding up planning with partitions |