Re: pg_partition_tree crashes for a non-defined relation

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Date: 2018-12-10 13:52:37
Message-ID: 20181210135237.GA1473@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 10, 2018 at 08:21:43AM -0500, Stephen Frost wrote:
> * Michael Paquier (michael(at)paquier(dot)xyz) wrote:
>> This still looks adapted to me. Or would you reword it because "allow"
>> rather implies that an ERROR is returned? Would you prefer changing it
>> something like that perhaps:
>> "Return NULL for relation types that do not appear in partition trees."
>
> Yes.

OK. Sure, let's do as you suggest then. I'll wait a couple of days
before committing the patch so as if someone has extra comments they
have the time to post. So please feel free to comment!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-10 13:56:47 Re: Should new partitions inherit their tablespace from their parent?
Previous Message Stephen Frost 2018-12-10 13:21:43 Re: pg_partition_tree crashes for a non-defined relation