| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should new partitions inherit their tablespace from their parent? |
| Date: | 2018-12-10 13:56:47 |
| Message-ID: | 20181210135647.GB1473@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 10, 2018 at 11:37:16PM +1300, David Rowley wrote:
> Likely it would be nice if we had a macro to determine if the relkind
> should have storage or not, and then just Assert() we get one of those
> into the function.
The other thread can deal about that matter I guess.
> For now, I've just changed the Assert to only pass when we get a
> partitioned table or partitioned index. I've left a comment to mention
> that other types may need to be added later. Assert failures should
> remind us to check that any newly added callers work correctly.
>
> Updated patch attached.
Cool, thanks for updating the assertion. At quick glance the patch
seems fine to me. Let's keep ATExecSetTableSpaceNoStorage as routine
name as you suggest then.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2018-12-10 13:56:50 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |
| Previous Message | Michael Paquier | 2018-12-10 13:52:37 | Re: pg_partition_tree crashes for a non-defined relation |