| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: pg_partition_tree crashes for a non-defined relation |
| Date: | 2018-12-10 13:21:43 |
| Message-ID: | 20181210132143.GJ3415@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Sun, Dec 09, 2018 at 12:49:18PM -0500, Stephen Frost wrote:
> > Looks alright on a quick glance, but shouldn't you also update the
> > comment..?
>
> The comment on HEAD or with the patch is that:
> /* Only allow relation types that can appear in partition trees. */
>
> This still looks adapted to me. Or would you reword it because "allow"
> rather implies that an ERROR is returned? Would you prefer changing it
> something like that perhaps:
> "Return NULL for relation types that do not appear in partition trees."
Yes.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-10 13:52:37 | Re: pg_partition_tree crashes for a non-defined relation |
| Previous Message | Stephen Frost | 2018-12-10 13:21:22 | Re: pg_partition_tree crashes for a non-defined relation |