RE: idle-in-transaction timeout error does not give a hint

From: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
To: 'Tatsuo Ishii' <ishii(at)sraoss(dot)co(dot)jp>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: idle-in-transaction timeout error does not give a hint
Date: 2018-12-04 04:07:34
Message-ID: 4E72940DA2BF16479384A86D54D0988A6F3C2DA3@G01JPEXMBKW04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>From: Tatsuo Ishii [mailto:ishii(at)sraoss(dot)co(dot)jp]
>Subject: Re: idle-in-transaction timeout error does not give a hint
>>>>>>Alternative HINT message would be something like:
>>>>>>HINT: In a moment you should be able to reconnect to the
>>>>>> database and restart your transaction.
>>>>>>This could make the meaning of the error (transaction aborted)
>>>>>>cleaner and might give a better suggestion to the user.
>>>>> Agreed. Changing "command" to "transaction" seems more accurate.
>>>>> People might think only the command they hit is not sent but
>>>>> transaction is still alive though it's of course unnatural that
>>>>> transaction is alive after
>>>connection is terminated.
>>>Please find attached patch which addresses the point above.
>> Thank you for the update. It looks good to me on this point.
>> Are you planning to change other similar messages?
>No, because this is the only message related to an explicit transaction. Other
>messages are not related to explicit transactions, so current messages look ok to me.

Sure. I didn't have a strong opinion about it, so it's ok.

Takeshi Ideriha

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-12-04 04:34:44 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Michael Paquier 2018-12-04 03:56:25 Re: [Todo item] Add entry creation timestamp column to pg_stat_replication