|From:||Stephen Frost <sfrost(at)snowman(dot)net>|
|To:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|Cc:||Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PATCH] Change "checkpoint starting" message to use "wal"|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> On 2018-Nov-29, Robert Haas wrote:
> > On Thu, Nov 29, 2018 at 4:10 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > > On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> > > > There's hundreds of other internal uses of xlog that were not touched
> > > > either, only the user-facing parts were changed.
> > >
> > > I have heard of them ;)
> > > Just wondering if this one is worth renaming as the variable is
> > > isolated. It is not a big deal to do nothing though.
> > Well, if we rename the user-visible part but not the internal part,
> > then they don't match, which is odd.
> But we already did that when we renamed all the xlog to WAL terminology
> ... why do we care about it now particularly?
I thought the idea was that we'd adjust things in the actual code as
that code was refactored or adjusted for other reasons, to minimize the
back-patching pain. That said, in this particular case that would mean
just changing one variable when the other related ones aren't changed
and I suspect that might just be more confusing than having this
difference between the code and the user-messages.
So, at least in this instance, my feeling is that we keep the variable
as-is and just adjust the user message. When, down the road, there's a
larger refactoring or change in this part of the code, that would be the
time to change the code to refer to WAL instead of XLOG.
|Next Message||Thomas Munro||2018-11-29 23:24:04||Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full|
|Previous Message||Andres Freund||2018-11-29 23:03:00||Re: pg_config wrongly marked as not parallel safe?|