Re: [PATCH] Change "checkpoint starting" message to use "wal"

From: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date: 2018-11-29 09:04:12
Message-ID: 20181129090412.GB9562@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Michael Paquier 2018-11-29 <20181129085902(dot)GD9004(at)paquier(dot)xyz>
> On Thu, Nov 29, 2018 at 09:47:09AM +0100, Christoph Berg wrote:
> > A customer was complaining that the "checkpoint starting: xlog"
> > message was not included in the grand PG10 rename of user-visible
> > bits. The attached patch fixes that.
>
> At the same time it would make sense to rename CHECKPOINT_CAUSE_XLOG? I
> would not risk back-patching such a change as that would be annoying for
> tools parsing logs like pgbadger.

There's hundreds of other internal uses of xlog that were not touched
either, only the user-facing parts were changed.

If this gets accepted, I'll submit a patch for pgbadger so it can be
updated before PG12 hits the field.

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-29 09:04:17 Re: Add pg_partition_tree to doc index
Previous Message Michael Paquier 2018-11-29 08:59:02 Re: [PATCH] Change "checkpoint starting" message to use "wal"