Re: pgsql: Add flag values in WAL description to all heap records

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add flag values in WAL description to all heap records
Date: 2018-11-15 15:33:35
Message-ID: 20181115153335.7doa3oiucn5hmbwn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2018-Nov-15, Michael Paquier wrote:

> On Wed, Nov 14, 2018 at 11:02:46AM -0300, Alvaro Herrera wrote:
> > Just noticed: ISTM we should also print the infobits_set flags in
> > xl_heap_lock and xl_heap_lock_updated. I can add those.
>
> OK, feel free to do so if you have time, or I can add them myself if
> you would like me to do so.

Now that I re-check, it's already done. Sorry for the noise.

> Another thing I was wondering is if we should show the information of
> individual tuples data for XLOG_HEAP2_FREEZE_PAGE records (under a
> different option?).

Not sure. Won't that become too verbose? I don't remember needing that
info for debugging.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-11-15 18:34:22 pgsql: Improve performance of partition pruning remapping a little.
Previous Message Alvaro Herrera 2018-11-15 15:20:33 Re: New Defects reported by Coverity Scan for PostgreSQL

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2018-11-15 16:48:52 Re: [HACKERS] generated columns
Previous Message Nikita Glukhov 2018-11-15 15:26:43 Re: [PATCH] Opclass parameters