| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |
| Date: | 2018-10-26 00:31:48 |
| Message-ID: | 20181026003148.GB3909@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 25, 2018 at 05:02:32PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Okay, revised patches attached. I also tweaked the CREATE EVENT TRIGGER
> completion to accept multple <filter_varaible> IN (<filter_value>)
> conditions seprated by AND in the WHEN clause (but not to suggest that,
> since we only actually support one <filter_variable>, TAG).
Committed 0001 now which adds tab completion for CREATE TRIGGER.
Something you missed is that we should still be able to complete with
PROCEDURE or FUNCTION (depending on the backend version) if CREATE
TRIGGER .. EXECUTE is present on screen. The priority is given to
complete with both EXECUTE PROCEDURE and EXECUTE FUNCTION at the same
time, but you also should have the intermediate state. I also added
some brackets for clarity, and a comment about the grammar selection.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2018-10-26 01:08:57 | RE: PostgreSQL Limits and lack of documentation about them. |
| Previous Message | Michael Paquier | 2018-10-25 23:56:00 | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |