| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |
| Date: | 2018-10-25 23:56:00 |
| Message-ID: | 20181025235600.GA3909@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 25, 2018 at 12:52:01PM +0100, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> To keep the code simple, you could do something like that, by checking
>> the head keywords for a match with CREATE TRIGGER, and then move all the
>> existing conditions within it:
>> ...
>> char *execute_keyword;
>> ...
>> blah and use execute_keyword in the lists;
>
> Don't think that works unless we remove some of the "const" annotation
> in COMPLETE_WITH; which I'd rather not.
Indeed, gcc just complained about the thing not being a constant after
testing, so please let me discard this suggestion.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-26 00:31:48 | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |
| Previous Message | Haribabu Kommi | 2018-10-25 22:40:29 | Re: PostgreSQL Limits and lack of documentation about them. |