Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
Date: 2018-10-26 04:52:34
Message-ID: 20181026045234.GD3909@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 26, 2018 at 09:31:48AM +0900, Michael Paquier wrote:
> Committed 0001 now which adds tab completion for CREATE TRIGGER.
> Something you missed is that we should still be able to complete with
> PROCEDURE or FUNCTION (depending on the backend version) if CREATE
> TRIGGER .. EXECUTE is present on screen. The priority is given to
> complete with both EXECUTE PROCEDURE and EXECUTE FUNCTION at the same
> time, but you also should have the intermediate state. I also added
> some brackets for clarity, and a comment about the grammar selection.

And 0002 is committed as well. Thanks for the patches!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-10-26 05:13:51 Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process
Previous Message Michael Paquier 2018-10-26 04:51:24 Re: Function to promote standby servers