Re: Refactor textToQualifiedNameList()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Subject: Re: Refactor textToQualifiedNameList()
Date: 2018-10-09 11:20:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Oct 09, 2018 at 10:47:48AM +0200, Pavel Stehule wrote:
> The difference on 10M calls is about 300ms - it is about 6%.

This number gives a good argument for rejecting this patch. I am not
usually against code beautification, but that's a high price to pay for
just some refactoring. On top of that, this potentially breaks
extension compilation.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-10-09 11:21:42 Re: Refactor textToQualifiedNameList()
Previous Message Michael Paquier 2018-10-09 11:17:20 Re: partition tree inspection functions