| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: Refactor textToQualifiedNameList() |
| Date: | 2018-10-09 11:21:42 |
| Message-ID: | CAFj8pRDMhrMz+8Sz7g5Xv8+NBh-FO9c9=qWfgm_yHqem_GHr_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
út 9. 10. 2018 v 13:20 odesílatel Michael Paquier <michael(at)paquier(dot)xyz>
napsal:
> On Tue, Oct 09, 2018 at 10:47:48AM +0200, Pavel Stehule wrote:
> > The difference on 10M calls is about 300ms - it is about 6%.
>
> This number gives a good argument for rejecting this patch. I am not
> usually against code beautification, but that's a high price to pay for
> just some refactoring. On top of that, this potentially breaks
> extension compilation.
>
ok
Regards
Pavel
--
> Michael
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-09 11:25:46 | Re: partition tree inspection functions |
| Previous Message | Michael Paquier | 2018-10-09 11:20:46 | Re: Refactor textToQualifiedNameList() |