| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marco Slot <marco(at)citusdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Onder Kalaci <onder(at)citusdata(dot)com> |
| Subject: | Re: Segfault when creating partition with a primary key and sql_drop trigger exists |
| Date: | 2018-10-05 23:54:54 |
| Message-ID: | 20181005235454.GA1197@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 05, 2018 at 04:04:02PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> On 2018-Oct-04, Tom Lane wrote:
>>> Not sure about that. Alvaro seems to think there's a generic problem
>>> in event trigger processing, which if true, was likely there pre-v11.
>
>> After sleeping on this, I think that a better answer is to fix the crash
>> per Michael's proposed patch, and fix the rest of the deparse problem
>> later.
>
> Well, let's push it sooner not later, so we can get buildfarm coverage
> before RC1.
I have to admit that I am not confident enough to commit this patch
myself yet as I would need to spend a couple of extra hours on it and
looking at the event triggers generated for other event types, and there
is a three-day weekend waiting ahead in Japan. Could any of you take
care of it?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-06 00:00:40 | Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1 |
| Previous Message | Tatsuo Ishii | 2018-10-05 23:17:04 | Creating Certificates |