test_pg_dump missing cleanup actions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, sfrost(at)snowman(dot)net
Subject: test_pg_dump missing cleanup actions
Date: 2018-09-04 20:30:12
Message-ID: 20180904203012.GG20696@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Stephen,

While hacking another patch, I have noticed that triggerring multiple
times in a row installcheck on test_pg_dump results in a failure because
it is missing clean up actions on the role regress_dump_test_role.
Roles are shared objects, so I think that we ought to not let traces of
it when doing any regression tests on a running instance.

Attached is a patch to clean up things.

Thanks,
--
Michael

Attachment Content-Type Size
test-pg-dump-cleanup.patch text/x-diff 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-09-04 20:58:18 Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.
Previous Message Andres Freund 2018-09-04 20:25:21 Re: Bug fix for glibc broke freebsd build in REL_11_STABLE