| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Date: | 2018-09-04 20:58:18 |
| Message-ID: | 20180904205818.GH20696@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 04, 2018 at 03:16:55PM -0400, Tom Lane wrote:
> Why would we invent a different target name? I was thinking something
> roughly like
>
> check: submake $(REGRESS_PREP)
> ifdef REGRESS
> $(pg_regress_check) $(REGRESS_OPTS) $(REGRESS)
> endif
> ifdef TAP_TESTS
> $(prove_check)
> endif
>
> although getting it to print a useful response when neither symbol
> is set would require complicating things a bit. Still, as long as
> there's just one copy of this rule, messiness isn't a big problem.
OK. I have dug into that, and finished with the attached. What do you
think? One thing is that the definition of submake is moving out of
REGRESS, and .PHONY gets defined.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| tap-pgxs.patch | text/x-diff | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-09-05 02:34:25 | pgsql: docs: improve AT TIME ZONE description |
| Previous Message | Tom Lane | 2018-09-04 19:16:55 | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-09-04 20:59:59 | Re: Bug fix for glibc broke freebsd build in REL_11_STABLE |
| Previous Message | Michael Paquier | 2018-09-04 20:30:12 | test_pg_dump missing cleanup actions |