Re: test_pg_dump missing cleanup actions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, sfrost(at)snowman(dot)net
Subject: Re: test_pg_dump missing cleanup actions
Date: 2018-09-04 21:44:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> While hacking another patch, I have noticed that triggerring multiple
> times in a row installcheck on test_pg_dump results in a failure because
> it is missing clean up actions on the role regress_dump_test_role.
> Roles are shared objects, so I think that we ought to not let traces of
> it when doing any regression tests on a running instance.

> Attached is a patch to clean up things.

I'm confused. Isn't the point of that script exactly to create a modified
extension for testing pg_dump with?

What I'd do is leave the final state as-is and add a "drop role if exists"
at the start, similar to what some of the core regression tests do.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-09-04 21:46:29 Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
Previous Message Alexander Korotkov 2018-09-04 21:16:39 Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun