| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jeremy Finzel <finzelj(at)gmail(dot)com>, Postgres General <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: found xmin from before relfrozenxid on pg_catalog.pg_authid |
| Date: | 2018-05-24 20:30:56 |
| Message-ID: | 20180524203054.k7lnxjbe2unfvsgm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On 2018-05-24 13:08:53 -0400, Alvaro Herrera wrote:
> Hmm .. surely
>
> diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
> index 5016181fd7..5d7fa1fb45 100644
> --- a/src/backend/access/heap/heapam.c
> +++ b/src/backend/access/heap/heapam.c
> @@ -6690,7 +6690,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple,
> xid = HeapTupleHeaderGetXmin(tuple);
> xmin_frozen = ((xid == FrozenTransactionId) ||
> HeapTupleHeaderXminFrozen(tuple));
> - if (TransactionIdIsNormal(xid))
> + if (!xmin_frozen && TransactionIdIsNormal(xid))
> {
> if (TransactionIdPrecedes(xid, relfrozenxid))
> ereport(ERROR,
>
>
> ??
I don't think that's necesary - HeapTupleHeaderGetXmin() returns
FrozenTransactionId if the tuple is frozen (note the
HeapTupleHeaderXminFrozen() within).
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-05-24 20:36:54 | Re: found xmin from before relfrozenxid on pg_catalog.pg_authid |
| Previous Message | Wong, Yi Wen | 2018-05-24 20:25:04 | Re: Error on vacuum: xmin before relfrozenxid |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-05-24 20:36:54 | Re: found xmin from before relfrozenxid on pg_catalog.pg_authid |
| Previous Message | Wong, Yi Wen | 2018-05-24 20:25:04 | Re: Error on vacuum: xmin before relfrozenxid |