| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jeremy Finzel <finzelj(at)gmail(dot)com>, Postgres General <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: found xmin from before relfrozenxid on pg_catalog.pg_authid |
| Date: | 2018-05-24 17:08:53 |
| Message-ID: | 20180524170853.gmep4arwx7i5m5o3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Hmm .. surely
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 5016181fd7..5d7fa1fb45 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -6690,7 +6690,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple,
xid = HeapTupleHeaderGetXmin(tuple);
xmin_frozen = ((xid == FrozenTransactionId) ||
HeapTupleHeaderXminFrozen(tuple));
- if (TransactionIdIsNormal(xid))
+ if (!xmin_frozen && TransactionIdIsNormal(xid))
{
if (TransactionIdPrecedes(xid, relfrozenxid))
ereport(ERROR,
??
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lele Gaifax | 2018-05-24 18:58:16 | Re: Parameter placeholders, $n vs ? |
| Previous Message | Paul Jungwirth | 2018-05-24 16:54:58 | Performance opportunities for write-only audit tables? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-05-24 17:13:23 | Portability concerns over pq_sendbyte? |
| Previous Message | Bruce Momjian | 2018-05-24 16:34:28 | Re: Should we add GUCs to allow partition pruning to be disabled? |