| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 'make check' fails |
| Date: | 2018-04-11 17:04:56 |
| Message-ID: | 18166.1523466296@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote:
>> We can fix this by making submake-generated-headers be a recursive
>> prerequisite for "check" as well as "all" and "install". I wonder
>> whether anybody is expecting any other shortcuts to work.
> In case it wasn't clear, I can reproduce this failure without parallel
> mode. FYI, the reason I used this shortcut is so I can just run one
> command and check one error code to know if they all worked; see
> src/tools/pgtest for an example.
Probably, you got out of the habit of using parallel mode because it
fell over from time to time. The way things were done before, there
were race conditions in this usage, due to different subdirectories
independently trying to update the same generated headers.
Will commit a fix in a bit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-11 17:06:12 | Re: Creation of wiki page for open items of v11 |
| Previous Message | Magnus Hagander | 2018-04-11 17:03:06 | Re: Creation of wiki page for open items of v11 |