Re: PATCH: Exclude unlogged tables from base backups

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Exclude unlogged tables from base backups
Date: 2018-03-26 07:33:56
Message-ID: CABOikdO-LL+-75ziNxDSRSZ7wY470yQExjkjw5Ucm15Qg7Ce3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 23, 2018 at 9:51 PM, David Steele <david(at)pgmasters(dot)net> wrote:

> On 3/23/18 12:14 PM, Teodor Sigaev wrote:
> >
> > Thank you, pushed
>
>
Is it just me or the newly added test in 010_pg_basebackup.pl failing for
others too?

# Failed test 'unlogged main fork not in backup'
# at t/010_pg_basebackup.pl line 112.
t/010_pg_basebackup.pl ... 86/87 # Looks like you failed 1 test of 87.

I manually ran pg_basebackup and it correctly excludes the main fork on an
unlogged table from the backup, but it consistently copies the main fork
while running "make check" and thus fails the test.

Thanks,
Pavan

--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-03-26 07:34:47 Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types
Previous Message Michael Paquier 2018-03-26 07:22:42 Re: PATCH: Configurable file mode mask