Re: non-bulk inserts and tuple routing

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: non-bulk inserts and tuple routing
Date: 2018-03-03 04:48:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-02-22 11:10:57 -0500, Robert Haas wrote:
> On Tue, Feb 20, 2018 at 8:06 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >> Attached is an updated version for that.
> >
> > Thanks for updating the patch.
> Committed with a few changes. The big one was that I got rid of the
> local variable is_update in ExecSetupPartitionTupleRouting. That
> saved a level of indentation on a substantial chunk of code, and it
> turns out that test was redundant anyway.

Btw, are there cases where this could change explain output? If there's
subplan references or such in any of returning / wcte expressions,
they'd not get added at explain time. It's probably fine because add
the expressions also "staticly" in ExecInitModifyTable()?


Andres Freund

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-03-03 05:08:45 Re: [HACKERS] GSOC'17 project introduction: Parallel COPY execution with errors handling
Previous Message Amit Kapila 2018-03-03 04:45:14 Re: heap_lock_updated_tuple_rec can leak a buffer refcount