| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Mark Dilger <hornschnorter(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: WIP: BRIN multi-range indexes |
| Date: | 2018-01-23 20:05:37 |
| Message-ID: | 20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This stuff sounds pretty nice. However, have a look at this report:
https://codecov.io/gh/postgresql-cfbot/postgresql/commit/2aa632dae3066900e15d2d42a4aad811dec11f08
it seems to me that the new code is not tested at all. Shouldn't you
add a few more tests?
I think 0004 should apply to unpatched master (except for the parts that
concern files not in master); sounds like a good candidate for first
apply. Then 0001, which seems mostly just refactoring. 0002 and 0003
are the really interesting ones (minus the code removed by 0004).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-01-23 21:04:49 | Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative |
| Previous Message | Daniel Gustafsson | 2018-01-23 19:59:18 | Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative |