| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Mark Dilger <hornschnorter(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: WIP: BRIN multi-range indexes |
| Date: | 2018-01-23 21:07:22 |
| Message-ID: | 821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/23/2018 09:05 PM, Alvaro Herrera wrote:
> This stuff sounds pretty nice. However, have a look at this report:
>
> https://codecov.io/gh/postgresql-cfbot/postgresql/commit/2aa632dae3066900e15d2d42a4aad811dec11f08
>
> it seems to me that the new code is not tested at all. Shouldn't you
> add a few more tests?
>
I have a hard time reading the report, but you're right I haven't added
any tests for the new opclasses (bloom and minmax_multi). I agree that's
something that needs to be addressed.
> I think 0004 should apply to unpatched master (except for the parts
> that concern files not in master); sounds like a good candidate for
> first apply. Then 0001, which seems mostly just refactoring. 0002 and
> 0003 are the really interesting ones (minus the code removed by
> 0004).
>
That sounds like a reasonable plan. I'll reorder the patch series along
those lines in the next few days.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2018-01-23 21:08:37 | Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative |
| Previous Message | Robert Haas | 2018-01-23 21:07:00 | Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation) |