| From: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Bug in ExecModifyTable function and trigger issues for foreign tables |
| Date: | 2017-09-12 15:26:22 |
| Message-ID: | 20170912182622.608b47c4@wp.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 24 Jul 2017 11:59:13 +0900
Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2017/07/21 19:16, Etsuro Fujita wrote:
> > On 2017/07/20 11:21, Etsuro Fujita wrote:
> >> On 2017/07/19 23:36, Tom Lane wrote:
> >>> Please put the responsibility of doing const-expression
> >>> simplification in these cases somewhere closer to where the
> >>> problem is being created.
> >>
> >> It would be reasonable that it's the FDW's responsibility to do
> >> that const-simplification if necessary?
> > There seems to be no objections, so I removed the const-expression
> > simplification from the patch and I added the note to the docs for
> > AddForeignUpdateTargets.
> >
> > Attached is an updated version of the patch.
>
> I cleaned up the patch a bit. PFA a new version of the patch.
>
> Best regards,
> Etsuro Fujita
Checked, looks good to me. Changed status to 'Ready for Commiter'.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-12 15:29:30 | Re: More efficient truncation of pg_stat_activity query strings |
| Previous Message | Aleksander Alekseev | 2017-09-12 15:23:57 | Re: Patches that don't apply or don't compile: 2017-09-12 |