Re: Bug in ExecModifyTable function and trigger issues for foreign tables

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Date: 2017-07-24 02:59:13
Message-ID: f8aa99d0-627d-32dc-fbc7-4e5943f9d652@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/07/21 19:16, Etsuro Fujita wrote:
> On 2017/07/20 11:21, Etsuro Fujita wrote:
>> On 2017/07/19 23:36, Tom Lane wrote:
>>> Please put the responsibility of doing const-expression simplification
>>> in these cases somewhere closer to where the problem is being created.
>>
>> It would be reasonable that it's the FDW's responsibility to do that
>> const-simplification if necessary?
> There seems to be no objections, so I removed the const-expression
> simplification from the patch and I added the note to the docs for
> AddForeignUpdateTargets.
>
> Attached is an updated version of the patch.

I cleaned up the patch a bit. PFA a new version of the patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
fix-rewrite-tlist-v4.patch text/plain 23.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-07-24 03:48:03 Re: pg_stop_backup(wait_for_archive := true) on standby server
Previous Message Claudio Freire 2017-07-24 01:18:23 Re: [WIP] [B-Tree] Keep indexes sorted by heap physical location