Re: pg_basebackup throttling doesn't throttle as promised

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup throttling doesn't throttle as promised
Date: 2017-09-05 15:41:12
Message-ID: 20170905154112.blblhncx7ryeylzb@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Jeff Janes wrote:
>
> > I'm attaching a patch for each option. Each one independently solves the
> > problem. But I think we should do both. There is no point in issuing
> > unnecessary kill system calls, and there may also be more spurious wake-ups
> > than just these ones.
>
> I modified patch 1 a bit -- result attached. I would like to back-patch
> this all the way back to 9.4, but there are a few conflicts due to
> c29aff959dc so I think I'm going to do pg10 only unless I get some votes
> that it should go further back. I think it should be fairly trivial to
> resolve.

Pushed patch 1 to master and pg10.

Please add the other one to commitfest.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-05 16:06:49 Re: proposal: psql: check env variable PSQL_PAGER
Previous Message Simon Riggs 2017-09-05 15:31:54 Re: Proposal for changes to recovery.conf API