Re: pg_basebackup throttling doesn't throttle as promised

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup throttling doesn't throttle as promised
Date: 2017-09-04 13:27:11
Message-ID: 20170904132711.koqlslbl4wjrfio5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Janes wrote:

> I'm attaching a patch for each option. Each one independently solves the
> problem. But I think we should do both. There is no point in issuing
> unnecessary kill system calls, and there may also be more spurious wake-ups
> than just these ones.

I modified patch 1 a bit -- result attached. I would like to back-patch
this all the way back to 9.4, but there are a few conflicts due to
c29aff959dc so I think I'm going to do pg10 only unless I get some votes
that it should go further back. I think it should be fairly trivial to
resolve.

The other patch should be applied to master only IMO.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-fix-basebackup-throttle.patch text/plain 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-09-04 13:38:14 Re: Proposal: pg_rewind to skip config files
Previous Message Adrien Nayrat 2017-09-04 12:57:08 Re: ALTER INDEX .. SET STATISTICS ... behaviour