From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Subject: | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
Date: | 2017-08-30 23:35:10 |
Message-ID: | CAKFQuwYoegUNB4yfK1s=JJ3TDLnJfQB05F647Mh61SGx0P7ogA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 30, 2017 at 4:08 PM, Bossart, Nathan <bossartn(at)amazon(dot)com>
wrote:
> On 8/30/17, 5:37 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Yeah... Each approach has its cost and its advantages. It may be
> > better to wait for more opinions, no many people have complained yet
> > that for example a list of columns using twice the same one fails.
>
> Sounds good to me.
>
> > +VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ <replaceable
> > class="PARAMETER">table_name</replaceable> ] [, ...]
> > I just noticed that... But regarding the docs, I think that you have
> > misplaced the position of "[, ...]", which should be inside the
> > table_name portion in the case of what I quote here, no?
>
> I think that's what I had initially, but it was changed somewhere along
> the line. It is a little more complicated for the versions that accept
> column lists.
>
> VACUUM ... ANALYZE [ [ table_name [ (column_name [, ...] ) ] ] [, ...] ]
>
> ISTM that we need the extra brackets here to clarify that the table and
> column list combination is what can be provided in a list. Does that
> make sense? Or do you think we can omit the outermost brackets here?
>
Inspired by the syntax documentation for EXPLAIN:
VACUUM [ ( option [, ...] ) ] [ table_def [, ...] ]
where option can be one of:
FULL
FREEZE
VERBOSE
DISABLE_PAGE_SKIPPING
and where table_def is:
table_name [ ( column_name [, ... ] ) ]
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-08-30 23:39:18 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
Previous Message | Bossart, Nathan | 2017-08-30 23:08:14 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |