| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot. |
| Date: | 2017-08-14 17:57:40 |
| Message-ID: | 20170814175740.v4ey4fejfpz4i4gk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2017-08-14 13:55:29 -0400, Peter Eisentraut wrote:
> On 8/12/17 07:32, Petr Jelinek wrote:
> > This commit has side effect that it makes it possible to export
> > snapshots on the standbys. This makes it possible to do pg_dump -j on
> > standby with consistent snapshot. Here is one line patch (+ doc update)
> > which allows doing that when pg_dumping from PG10+.
> >
> > I also wonder if it should be mentioned in release notes. If the
> > attached patch would make it into PG10 it would be no brainer to mention
> > it as feature under pg_dump section, but exporting snapshots alone I am
> > not sure about.
>
> Any other opinions on this patch?
I'd be oh so very slightly inclined to push this, including the modified
pg_dump check. We're going to be on the hook for supporting snapshots on
standbys anyway, unless we put in additional unnecessary error check.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-14 19:43:36 | pgsql: Handle elog(FATAL) during ROLLBACK more robustly. |
| Previous Message | Peter Eisentraut | 2017-08-14 17:55:29 | Re: Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-14 18:00:57 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |
| Previous Message | Peter Eisentraut | 2017-08-14 17:55:29 | Re: Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot. |