From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot. |
Date: | 2017-08-16 23:50:39 |
Message-ID: | ab46c68a-26a0-988f-2b01-16309ee1c60c@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 8/14/17 13:57, Andres Freund wrote:
> On 2017-08-14 13:55:29 -0400, Peter Eisentraut wrote:
>> On 8/12/17 07:32, Petr Jelinek wrote:
>>> This commit has side effect that it makes it possible to export
>>> snapshots on the standbys. This makes it possible to do pg_dump -j on
>>> standby with consistent snapshot. Here is one line patch (+ doc update)
>>> which allows doing that when pg_dumping from PG10+.
>>>
>>> I also wonder if it should be mentioned in release notes. If the
>>> attached patch would make it into PG10 it would be no brainer to mention
>>> it as feature under pg_dump section, but exporting snapshots alone I am
>>> not sure about.
>>
>> Any other opinions on this patch?
>
> I'd be oh so very slightly inclined to push this, including the modified
> pg_dump check. We're going to be on the hook for supporting snapshots on
> standbys anyway, unless we put in additional unnecessary error check.
committed to 10 and master
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-08-17 00:22:27 | Re: [COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges |
Previous Message | Peter Eisentraut | 2017-08-16 23:50:09 | pgsql: pg_dump: Support using synchronized snapshots on standbys |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-08-16 23:57:34 | Re: [HACKERS] Replication to Postgres 10 on Windows is broken |
Previous Message | Michael Paquier | 2017-08-16 23:41:38 | Re: [HACKERS] Replication to Postgres 10 on Windows is broken |