| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A couple of postgresql.conf.sample discrepancies |
| Date: | 2017-07-27 08:27:29 |
| Message-ID: | 20170727082729.GA4070@e733.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Thomas,
> Here's a script that reminds you about GUCs you forgot to put in
> postgresql.conf.sample. It probably needs some work. Does this
> already happen somewhere else? I guess not, because it found two
> discrepancies:
>
> $ ./src/tools/check_sample_config.pl
> enable_gathermerge appears in guc.c but not in postgresql.conf.sample
> trace_recovery_messages appears in guc.c but not in postgresql.conf.sample
I like the idea. However maybe it worth considering to turn it into a
TAP test? Otherwise there is a good chance everybody will forget to run
it. For similar reason I would advise to add this patch to the next
commitfest.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-07-27 08:30:51 | Re: Increase Vacuum ring buffer. |
| Previous Message | Kunshchikov Vladimir | 2017-07-27 07:34:22 | Re: [patch] pg_dump/pg_restore zerror() and strerror() mishap |