From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A couple of postgresql.conf.sample discrepancies |
Date: | 2017-07-27 10:35:54 |
Message-ID: | CAB7nPqQNoO60JhKCBT=gj=N-fidVAO1h9zV_Y41JLD=hK64Lsw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 27, 2017 at 10:27 AM, Aleksander Alekseev
<a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>> Here's a script that reminds you about GUCs you forgot to put in
>> postgresql.conf.sample. It probably needs some work. Does this
>> already happen somewhere else? I guess not, because it found two
>> discrepancies:
>>
>> $ ./src/tools/check_sample_config.pl
>> enable_gathermerge appears in guc.c but not in postgresql.conf.sample
>> trace_recovery_messages appears in guc.c but not in postgresql.conf.sample
>
> I like the idea. However maybe it worth considering to turn it into a
> TAP test? Otherwise there is a good chance everybody will forget to run
> it. For similar reason I would advise to add this patch to the next
> commitfest.
Bonus points if the script can detect that a parameter's comment
forgets to include "(change requires restart)".
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-07-27 10:39:51 | Re: asynchronous execution |
Previous Message | Arseny Sher | 2017-07-27 10:02:39 | Re: expand_dbname in postgres_fdw |