Re: Fix a typo in snapmgr.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in snapmgr.c
Date: 2017-06-07 17:17:31
Message-ID: 20170607171731.2qadymah3afi6rqb@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-05-08 09:12:13 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > So rearranged code a little to keep it lean.
>
> Didn't you break it with that? As it now stands, the memcpy will
> copy the nonzero value.

I've not seen a fix and/or alleviating comment about this so far. Did I
miss something?

- Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-06-07 17:25:11 Re: Parallel Aggregation support for aggregate functions that use transitions not implemented for array_agg
Previous Message Robert Haas 2017-06-07 17:12:02 Re: HACKERS[PROPOSAL] split ProcArrayLock into multiple parts