| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix a typo in snapmgr.c |
| Date: | 2017-06-08 02:58:19 |
| Message-ID: | CAD21AoCT+73jJv-LJNMEd0ayvknQ2Q0ZWfgtHRFSN5jzExq6wA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 8, 2017 at 2:17 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-05-08 09:12:13 -0400, Tom Lane wrote:
>> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
>> > So rearranged code a little to keep it lean.
>>
>> Didn't you break it with that? As it now stands, the memcpy will
>> copy the nonzero value.
>
> I've not seen a fix and/or alleviating comment about this so far. Did I
> miss something?
>
I think we don't have the fix for the comment from Tom so far, too.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-08 03:28:02 | Does pg_upgrade really support "make installcheck"? |
| Previous Message | Tom Lane | 2017-06-08 02:01:57 | Re: PostgreSQL 10 changes in exclusion constraints - did something change? CASE WHEN behavior oddity |