Re: Fix a typo in snapmgr.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in snapmgr.c
Date: 2017-05-08 13:12:13
Message-ID: 3331.1494249133@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> So rearranged code a little to keep it lean.

Didn't you break it with that? As it now stands, the memcpy will
copy the nonzero value.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniele Varrazzo 2017-05-08 13:12:55 Re: Detecting schema changes during logical replication
Previous Message Dmitriy Sarafannikov 2017-05-08 13:00:18 Re: [PROPOSAL] Use SnapshotAny in get_actual_variable_range