| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| Date: | 2017-05-29 21:06:49 |
| Message-ID: | 20170529210649.ayz5hnilprnggvut@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Michael Paquier wrote:
> On Mon, May 29, 2017 at 1:43 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > Daniele Varrazzo wrote:
> >> Patch attached
> >
> > Uh, shouldn't the parenthical comment be errdetail()?
>
> FWIW, this did not strike me as necessary for this one as well all the
> other error messages in auth-scram.c as the main error strings are
> short, and the extra information looked adapted as part of the main
> error message.
To me this sounds like you're uttering "beetlejuice" thrice to summon
the message-style police.
These messages look all wrong to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | s.bondarev | 2017-05-29 21:07:21 | BUG #14678: PGDG Rhel6 repo contain packet for Rhel7 system |
| Previous Message | Дмитрий Сергеевич | 2017-05-29 20:58:14 | Danger |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-29 21:12:51 | Re: pg_resetwal is broken if run from v10 against older version of PG data directory |
| Previous Message | Mark Kirkwood | 2017-05-29 21:06:48 | Re: logical replication - still unstable after all these months |