| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| Date: | 2017-05-29 20:49:05 |
| Message-ID: | CAB7nPqTg=TDx6w32z6BX+2wHcK9SNiLFKw-YNsr3R9iWcVQjEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, May 29, 2017 at 1:43 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Daniele Varrazzo wrote:
>> Patch attached
>
> Uh, shouldn't the parenthical comment be errdetail()?
FWIW, this did not strike me as necessary for this one as well all the
other error messages in auth-scram.c as the main error strings are
short, and the extra information looked adapted as part of the main
error message.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Дмитрий Сергеевич | 2017-05-29 20:58:14 | Danger |
| Previous Message | Alvaro Herrera | 2017-05-29 20:43:55 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-05-29 21:01:12 | Re: Bug when dumping "empty" operator classes |
| Previous Message | Alvaro Herrera | 2017-05-29 20:43:55 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |