Re: parallel bitmapscan isn't exercised in regression tests

From: Andres Freund <andres(at)anarazel(dot)de>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel bitmapscan isn't exercised in regression tests
Date: 2017-04-06 20:43:55
Message-ID: 20170406204355.b4owz73rv2zlkpxs@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-04-06 10:00:32 +0530, Dilip Kumar wrote:
> On Tue, Apr 4, 2017 at 5:51 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > Sure I can do that, In attached patch, I only fixed the problem of not
> > executing the bitmap test. Now, I will add few cases to cover other
> > parts especially rescan and prefetching logic.
>
> I have added two test cases to cover rescan, prefetch and lossy pages
> logic for parallel bitmap. I have removed the existing case because
> these two new cases will be enough to cover that part as well.
>
> Now, nodeBitmapHeapScan.c has 95.5% of line coverage.

Great! Pushed.

- Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-06 20:50:19 Re: parallel explain analyze support not exercised
Previous Message Andres Freund 2017-04-06 20:43:48 pgsql: Increase parallel bitmap scan test coverage.