| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: parallel bitmapscan isn't exercised in regression tests |
| Date: | 2017-04-06 04:30:32 |
| Message-ID: | CAFiTN-uUYdhhOFw0UdT6t_nREnJgqo3KR14eGLhH7N68XB48VQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 4, 2017 at 5:51 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Sure I can do that, In attached patch, I only fixed the problem of not
> executing the bitmap test. Now, I will add few cases to cover other
> parts especially rescan and prefetching logic.
I have added two test cases to cover rescan, prefetch and lossy pages
logic for parallel bitmap. I have removed the existing case because
these two new cases will be enough to cover that part as well.
Now, nodeBitmapHeapScan.c has 95.5% of line coverage.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| parallel_bitmap_test_v2.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-04-06 05:00:55 | Re: Bug with pg_basebackup and 'shared' tablespace |
| Previous Message | Jim Nasby | 2017-04-06 04:10:11 | Re: Faster methods for getting SPI results (460% improvement) |