Re: parallel bitmapscan isn't exercised in regression tests

From: Andres Freund <andres(at)anarazel(dot)de>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel bitmapscan isn't exercised in regression tests
Date: 2017-04-07 17:50:03
Message-ID: 20170407175003.4xoa55lxbfenbac5@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-04-06 13:43:55 -0700, Andres Freund wrote:
> On 2017-04-06 10:00:32 +0530, Dilip Kumar wrote:
> > On Tue, Apr 4, 2017 at 5:51 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > > Sure I can do that, In attached patch, I only fixed the problem of not
> > > executing the bitmap test. Now, I will add few cases to cover other
> > > parts especially rescan and prefetching logic.
> >
> > I have added two test cases to cover rescan, prefetch and lossy pages
> > logic for parallel bitmap. I have removed the existing case because
> > these two new cases will be enough to cover that part as well.
> >
> > Now, nodeBitmapHeapScan.c has 95.5% of line coverage.
>
> Great! Pushed.

At some point it might also be a good idea to compare parallel and
non-parallel results. It's obviously quite possible to break semantics
with parallelism...

- Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-07 17:52:44 Re: recent deadlock regression test failures
Previous Message Kevin Grittner 2017-04-07 17:49:22 Re: recent deadlock regression test failures