Re: Possible spelling fixes

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Josh Soref <jsoref(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible spelling fixes
Date: 2017-03-01 18:20:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017-03-01 14:40:26 -0300, Alvaro Herrera wrote:
> Josh Soref wrote:
> > One thing that would be helpful is if someone could comment on:
> >
> > -#undef SH_ITERTOR
> > +#undef SH_ITERATOR
> >
> > It's unclear to me what that line is/was doing. It's possible that it
> > could be removed entirely instead of having its spelling changed.
> > If the line is trying to guard against a previous version of the code,
> > which is no longer active, then it deserves a comment.
> AFAICS this is a bug. This file can potentially be included several
> times by the same C source, and it defines SH_ITERATOR every time. The
> second time it needs to be #undef'ed prior, which this line is supposed
> to do but fails because of the typo.

Indeed. Fixed, thanks for noticing.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2017-03-01 18:20:41 Re: ANALYZE command progress checker
Previous Message Tels 2017-03-01 18:12:36 Re: PassDownLimitBound for ForeignScan/CustomScan [take-2]