|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||Josh Soref <jsoref(at)gmail(dot)com>|
|Cc:||Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Possible spelling fixes|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Josh Soref wrote:
> One thing that would be helpful is if someone could comment on:
> -#undef SH_ITERTOR
> +#undef SH_ITERATOR
> It's unclear to me what that line is/was doing. It's possible that it
> could be removed entirely instead of having its spelling changed.
> If the line is trying to guard against a previous version of the code,
> which is no longer active, then it deserves a comment.
AFAICS this is a bug. This file can potentially be included several
times by the same C source, and it defines SH_ITERATOR every time. The
second time it needs to be #undef'ed prior, which this line is supposed
to do but fails because of the typo.
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Alvaro Herrera||2017-03-01 17:58:06||Re: Patch: Optimize memory allocation in function 'bringetbitmap'|
|Previous Message||Pavel Stehule||2017-03-01 17:34:05||Re: SQL/JSON in PostgreSQL|