| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-01-19 15:12:18 |
| Message-ID: | 20170119151218.ozzkc5oznubkxqiu@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Karl O. Pinc wrote:
> On Wed, 18 Jan 2017 19:27:40 -0300
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > I thought this part was odd -- I mean, why is SysLogger_Start() being
> > called if the collector is not enabled? Turns out we do it and return
> > early if not enabled. But not in all cases -- there is one callsite
> > in postmaster.c that avoids the call if the collector is disabled.
> > That needs to be changed if we want this to work reliably.
>
> Is this an argument for having the current_logfiles always exist
> and be empty when there is no in-filesystem logfile? It always felt
> to me that the code would be simpler that way.
I don't know. I am just saying that you need to patch postmaster.c line
1726 to remove the second arm of the &&.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-19 15:26:14 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Karl O. Pinc | 2017-01-19 15:08:59 | Re: Patch to implement pg_current_logfile() function |