From: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
---|---|
To: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to implement pg_current_logfile() function |
Date: | 2017-01-19 18:29:35 |
Message-ID: | 20170119122935.14eba51b@slate.meme.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 19 Jan 2017 12:12:18 -0300
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Karl O. Pinc wrote:
> > On Wed, 18 Jan 2017 19:27:40 -0300
> > Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> > > I thought this part was odd -- I mean, why is SysLogger_Start()
> > > being called if the collector is not enabled? Turns out we do it
> > > and return early if not enabled. But not in all cases -- there
> > > is one callsite in postmaster.c that avoids the call if the
> > > collector is disabled. That needs to be changed if we want this
> > > to work reliably.
> >
> > Is this an argument for having the current_logfiles always exist
> > and be empty when there is no in-filesystem logfile? It always felt
> > to me that the code would be simpler that way.
>
> I don't know. I am just saying that you need to patch postmaster.c
> line 1726 to remove the second arm of the &&.
Gilles,
I'm not available just now. Can you do this or enlist Michael?
Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-01-19 19:08:49 | Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups |
Previous Message | Erik Rijkers | 2017-01-19 18:27:54 | Re: Logical Replication WIP - FailedAssertion, File: "array_typanalyze.c", Line: 340 |