Re: Logical Replication WIP - FailedAssertion, File: "array_typanalyze.c", Line: 340

On 2017-01-19 19:12, Petr Jelinek wrote:
> On 19/01/17 18:44, Erik Rijkers wrote:
>>
>> Could probably be whittled down to something shorter but I hope it's
>> still easily reproduced.
>>
>
> Just analyze on the pg_subscription is enough.

heh. Ah well, I did find it :)

Can you give the current patch set? I am failing to get a compilable
set.

In the following order they apply, but then fail during compile.

0001-Add-PUBLICATION-catalogs-and-DDL-v18.patch
0002-Add-SUBSCRIPTION-catalog-and-DDL-v18.patch
0003-Define-logical-replication-protocol-and-output-plugi-v18.patch
0004-Add-logical-replication-workers-v18fixed.patch
0006-Add-RENAME-support-for-PUBLICATIONs-and-SUBSCRIPTION.patch
0001-Logical-replication-support-for-initial-data-copy-v3.patch
pg_subscription-analyze-fix.diff

The compile fails with:

In file included from ../../../../src/include/postgres.h:47:0,
from worker.c:27:
worker.c: In function ‘create_estate_for_relation’:
../../../../src/include/c.h:203:14: warning: passing argument 4 of
‘InitResultRelInfo’ makes pointer from integer without a cast
[-Wint-conversion]
#define true ((bool) 1)
^
worker.c:187:53: note: in expansion of macro ‘true’
InitResultRelInfo(resultRelInfo, rel->localrel, 1, true, NULL, 0);
^~~~
In file included from ../../../../src/include/funcapi.h:21:0,
from worker.c:31:
../../../../src/include/executor/executor.h:189:13: note: expected
‘Relation {aka struct RelationData *}’ but argument is of type ‘char’
extern void InitResultRelInfo(ResultRelInfo *resultRelInfo,
^~~~~~~~~~~~~~~~~
worker.c:187:59: warning: passing argument 5 of ‘InitResultRelInfo’
makes integer from pointer without a cast [-Wint-conversion]
InitResultRelInfo(resultRelInfo, rel->localrel, 1, true, NULL, 0);
^~~~
In file included from ../../../../src/include/funcapi.h:21:0,
from worker.c:31:
../../../../src/include/executor/executor.h:189:13: note: expected ‘int’
but argument is of type ‘void *’
extern void InitResultRelInfo(ResultRelInfo *resultRelInfo,
^~~~~~~~~~~~~~~~~
worker.c:187:2: error: too many arguments to function
‘InitResultRelInfo’
InitResultRelInfo(resultRelInfo, rel->localrel, 1, true, NULL, 0);
^~~~~~~~~~~~~~~~~
In file included from ../../../../src/include/funcapi.h:21:0,
from worker.c:31:
../../../../src/include/executor/executor.h:189:13: note: declared here
extern void InitResultRelInfo(ResultRelInfo *resultRelInfo,
^~~~~~~~~~~~~~~~~
make[4]: *** [worker.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [logical-recursive] Error 2
make[2]: *** [replication-recursive] Error 2
make[2]: *** Waiting for unfinished jobs....
^[make[1]: *** [all-backend-recurse] Error 2
make: *** [all-src-recurse] Error 2

but perhaps that patchset itself is incorrect, or the order in which I
applied them.

Can you please put them in the right order? (I tried already a few...)

thanks,

Erik Rijkers