Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Date: 2016-10-12 23:38:38
Message-ID: 20161012233838.ijc5whv4f5u72zq7@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2016-10-12 11:18:57 -0400, Peter Eisentraut wrote:
> On 10/4/16 11:29 AM, Tom Lane wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> Apparently, 'make world' does not build worker_spi. I thought 'make
> >> world' was supposed to build everything?
> >
> > You'd have thunk, yeah. It looks like the issue is that src/Makefile
> > is selective about recursing into certain subdirectories of test/,
> > but mostly not test/ itself. src/test/Makefile naively believes it's
> > in charge, though. Probably that logic ought to get shoved down one
> > level, and then adjusted so that src/test/modules gets built by "all".
> > Or else teach top-level "make world" to do "make all" in src/test/,
> > but that seems like it's just doubling down on confusing interconnections.
>
> We generally don't build test code during make world.

FWIW, I find that quite annoying. I want to run make world with parallelism so
I can run make world afterwards with as little unnecessary
unparallelized work. And since the latter takes just about forever, any
errors visible earlier are good.

What are we gaining by this behaviour?

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-10-13 00:10:20 pgsql: Remove spurious word.
Previous Message Tom Lane 2016-10-12 22:02:28 pgsql: Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-10-12 23:44:57 Re: macaddr 64 bit (EUI-64) datatype support
Previous Message Merlin Moncure 2016-10-12 23:03:17 Re: munmap() failure due to sloppy handling of hugepage size